cache source and --force for type checkers#23109
Open
cburroughs wants to merge 1 commit intopantsbuild:mainfrom
Open
cache source and --force for type checkers#23109cburroughs wants to merge 1 commit intopantsbuild:mainfrom
cburroughs wants to merge 1 commit intopantsbuild:mainfrom
Conversation
This started as adding --force because I had confused myself several times benchmarking and forgetting to dirty the right cache at the right time. I think that like `--test-force`, `--check-force` "shouldn't" be needed, but sometimes it is. (Since the case is more marginal for checking we could make it `advanced`, but leaned towards the consistency with the test goal.) I couldn't mirror the `--test-force` test without widening the scope to pass along `RunId`. That was added for pantsbuild#13889 which would also be valuable for all the same reasons exposing that information for tests was. (To be clear, I was not aware that `pants check ::` could be "cached locally"!) The Golang/JVM subsystems approach type checking is different (aka the compiler does it) and are thus unchanged. Typescript is another different challenge because it partitions by directory. Added a flag so that typescript can retain the old 'single line' `✓ typescript succeeded.` behavior since getting a line for each directory seemed like far too much. (I fiddled a bit with trying to get repositories with only a single (resolve,IC) to omit the partition name but I didn't like what the coupling looked like.)
cburroughs
force-pushed
the
csb/check-force
branch
from
1e584d6 to
5c04793
Compare
Contributor
Author
|
(Re test failure --> #23108) |
Contributor
|
I didn't realise the --test-force option existed for tests. Should it be added here? docs/using-pants/troubleshooting-common-issues How would users expect this to work with named_caches - e.g. the mypy cache? As proposed, mypy cache would still be used. Thanks for the report re. node lockfiles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as adding --force because I had confused myself several times benchmarking and forgetting to dirty the right cache at the right time. I think that like
--test-force,--check-force"shouldn't" be needed, but sometimes it is. (Since the case is more marginal for checking we could make itadvanced, but leaned towards the consistency with the test goal.)I couldn't mirror the
--test-forcetest without widening the scope to pass alongRunId. That was added for #13889 which would also be valuable for all the same reasons exposing that information for tests was. (To be clear, I was not aware thatpants check ::could be "cached locally"!)The Golang/JVM subsystems approach type checking is different (aka the compiler does it) and are thus unchanged.
Typescript is another different challenge because it partitions by directory. Added a flag so that typescript can retain the old 'single line'
✓ typescript succeeded.behavior since getting a line for each directory seemed like far too much.(I fiddled a bit with trying to get repositories with only a single (resolve,IC) to omit the partition name but I didn't like what the coupling looked like.)