Skip to content

Enhance documentation on binary tool download issues#23110

Open
DLukeNelson wants to merge 1 commit intopantsbuild:mainfrom
DLukeNelson:patch-1
Open

Enhance documentation on binary tool download issues#23110
DLukeNelson wants to merge 1 commit intopantsbuild:mainfrom
DLukeNelson:patch-1

Conversation

@DLukeNelson
Copy link
Contributor

Added troubleshooting steps for downloading tools in restricted internet access settings.

There were previous slack threads on this issue, but here is the link to my thread: https://pantsbuild.slack.com/archives/C046T6T9U/p1771439042756269

Added troubleshooting steps for downloading tools in restricted internet access settings.
@jsirois
Copy link
Contributor

jsirois commented Feb 20, 2026

I was part of the linked slack conversation and this change has me confused. It's submitted against 2.32.0.dev1 which has the fix in pantsd (in other words the new help information does not apply). Also 2.31.0 was released yesterday; so there is a production version with said fix as well. There is 0 mention in the new help text that the fix should only be needed in Pants < 2.31.0 and so the help text can only really be useful to a user of older Pants that is reading the wrong documentation (docs for Pants newer than theirs). Pants regularly makes me think I'm insane; so I may be missing something here.

@DLukeNelson
Copy link
Contributor Author

I was part of the linked slack conversation and this change has me confused. It's submitted against 2.32.0.dev1 which has the fix in pantsd (in other words the new help information does not apply). Also 2.31.0 was released yesterday; so there is a production version with said fix as well. There is 0 mention in the new help text that the fix should only be needed in Pants < 2.31.0 and so the help text can only really be useful to a user of older Pants that is reading the wrong documentation (docs for Pants newer than theirs). Pants regularly makes me think I'm insane; so I may be missing something here.

I think I missed reading between the lines that the issue was resolved in 2.31. With that in mind, then yeah, I'd agree this wouldn't make a lot of sense to add in where it is.

I'll admit to not fully understanding the release/versioning/docs strategy. I mostly just wanted to write down what I learned while it was fresh and get it out so we can figure out where best to put it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments