feat: Introduce auto-updating strings objects#549
Draft
krlade wants to merge 26 commits intopaper-plane-developers:mainfrom
Draft
feat: Introduce auto-updating strings objects#549krlade wants to merge 26 commits intopaper-plane-developers:mainfrom
krlade wants to merge 26 commits intopaper-plane-developers:mainfrom
Conversation
krlade
force-pushed
the
subtitle
branch
2 times, most recently
from
a53cb9b to
9195097
Compare
krlade
changed the title
Contributor
Author
|
|
krlade
commented
Jun 17, 2023
| match chat.type_() { | ||
| ChatType::Private(user) => { | ||
| self.setup_user_info(user); | ||
| // TODO: Add handle own chat; |
marhkb
requested changes
Jul 8, 2023
src/tdlib/chat.rs
Outdated
Comment on lines
143
to
145
| glib::ParamSpecInt::builder("online-member-count") | ||
| .read_only() | ||
| .build(), |
src/strings/user_status_string.rs
Outdated
|
|
||
| #[derive(Debug, Default)] | ||
| pub(crate) struct UserStatusString { | ||
| pub(super) user: OnceCell<User>, |
| } | ||
|
|
||
| impl UserStatusString { | ||
| pub(crate) fn new(user: User) -> UserStatusString { |
Collaborator
There was a problem hiding this comment.
Should also implement From trait.
src/strings/user_status_string.rs
Outdated
Comment on lines
119
to
132
| if matches!(user.type_().0, UserType::Bot(_)) { | ||
| gettext("bot") | ||
| } else { | ||
| strings::user_status(&user.status().0) | ||
| } |
Collaborator
There was a problem hiding this comment.
Please use match for such things.
src/strings/user_status_string.rs
Outdated
| }), | ||
| ); | ||
|
|
||
| if let UserStatus::Offline(data) = user.status().0 { |
Collaborator
There was a problem hiding this comment.
Please no if let else. match is more readable
src/strings/user_status_string.rs
Outdated
| _ => { | ||
| if let Some(source) = self.imp().source_id.take() { | ||
| source.remove(); | ||
| self.imp().source_id.replace(None); |
Collaborator
There was a problem hiding this comment.
take already sets None. So, this line is obsolete.
src/session/content/chat_history.rs
Outdated
| pub(super) list_view: TemplateChild<gtk::ListView>, | ||
| #[template_child] | ||
| pub(super) chat_action_bar: TemplateChild<ChatActionBar>, | ||
| pub binding: RefCell<Option<gtk::ExpressionWatch>>, |
| if let Some(action) = chat.actions().last() { | ||
| should_show_actions | ||
| .then(|| strings::chat_action(&action)) | ||
| .unwrap_or(String::new()) |
Contributor
Author
There was a problem hiding this comment.
right, it's the same, but looks much better
| if !chat.is_own_chat() { | ||
| match chat.type_() { | ||
| ChatType::Private(_) | ChatType::Secret(_) => { | ||
| if !chat.is_own_chat() { |
Comment on lines
+119
to
+121
| .try_borrow() | ||
| .ok() | ||
| .and_then(|l| l.last().map(|(_, action)| action.clone())) |
Collaborator
There was a problem hiding this comment.
This doesn't seem to be correct.
Contributor
Author
There was a problem hiding this comment.
Basically, I've changed it because it was borrowed mutable multiple times and I didn't know how to fix this. I realized my workaround causes new problems, but left it for now since this pr is not ready to merge anyway.
Currently translated at 100.0% (262 of 262 strings) Translation: Paper Plane/Main Translate-URL: https://hosted.weblate.org/projects/paper-plane/main/pt/
Currently translated at 100.0% (262 of 262 strings) Translation: Paper Plane/Main Translate-URL: https://hosted.weblate.org/projects/paper-plane/main/pl/
Currently translated at 100.0% (262 of 262 strings) Translation: Paper Plane/Main Translate-URL: https://hosted.weblate.org/projects/paper-plane/main/pt/
Currently translated at 81.6% (214 of 262 strings) Translation: Paper Plane/Main Translate-URL: https://hosted.weblate.org/projects/paper-plane/main/ru/
These categories were taken form the desktop file of the official client.
Some of them were taken form the desktop file of the official client.
Currently translated at 100.0% (262 of 262 strings) Translation: Paper Plane/Main Translate-URL: https://hosted.weblate.org/projects/paper-plane/main/tr/
Currently translated at 100.0% (262 of 262 strings) Translation: Paper Plane/Main Translate-URL: https://hosted.weblate.org/projects/paper-plane/main/tr/
With mask it correctly matches message bubble background
We shouldn't assume that the current locale has an equivalent country code. We need to check this and set an invalid country code in this case to fix a crash. Fixes paper-plane-developers#559
Avoid defining properties when not needed and move tdlib "use" definitions.
Change send button style and stop using chat name as window title.
Also fix a crash that was caused from this update.
Tell tdlib to open selected and close unselected chat. This is needed to recieve some updates e.g. ChatOnlineMemberCount
Contributor
Author
|
Oh Jeez, 26 commits 👀 I'm master of git 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary