Add tests for send & execute xcm messages snippets#8
Open
Conversation
albertov19
requested changes
Apr 12, 2023
Contributor
albertov19
left a comment
albertov19
left a comment
There was a problem hiding this comment.
Overall it looks great!!! I left a comment on the encoded call data as I think you did to executes and not a send
test/builders/interoperability/xcm/send-execute-xcm-messages/encodedCalldata.js
Outdated
Show resolved
Hide resolved
test/builders/interoperability/xcm/send-execute-xcm-messages/encodedCalldata.js
Outdated
Show resolved
Hide resolved
albertov19
approved these changes
Apr 28, 2023
test/builders/interoperability/xcm/send-execute-xcm-messages/encodedCalldata.js
Outdated
Show resolved
Hide resolved
Contributor
|
Anything pending here @eshaben ? |
Contributor
Author
|
Yes, the existing tests needed to be updated. Plus, additional scripts were added since this was originally created, so more tests need to be added. I got about halfway through this process, so I just need to wrap that up and I'll re-request a review |
Contributor
Author
|
Changes have been applied. This can be reviewed again now, please! @albertov19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the snippets found on this page: https://docs.moonbeam.network/builders/interoperability/xcm/send-execute-xcm/
Our first XCM-related tests! 🎉
Thank you thank you thank you to @mario-purestake for helping with the python test runner!!