Skip to content

Conversation

@jrobichaud
Copy link
Contributor

@jrobichaud jrobichaud commented Dec 2, 2024

Todo:

  • test different scenarios
  • avoid having to create the task in the view if possible
  • implement tests

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (baacd9e) to head (77e4db7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           93       153   +60     
=========================================
+ Hits            93       153   +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrobichaud
Copy link
Contributor Author

It's ready for review.

@jrobichaud jrobichaud changed the title ASGI is maybe back again ASGI support Dec 3, 2024
Copy link
Owner

@paqstd-dev paqstd-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful idea with the asynchronous processing. Wrote a few comments for discussion.

Copy link
Owner

@paqstd-dev paqstd-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right. I think we can merge it.

@paqstd-dev paqstd-dev merged commit 7068981 into paqstd-dev:main Dec 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants