chore!: Populate the headers field in the ExecutionWitness when calling debug_executionWitness
#15608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Apr 8, 2025
kevaundray
commented
Apr 8, 2025
kevaundray
commented
Apr 8, 2025
kevaundray
changed the title
rkrasiuk
reviewed
Apr 9, 2025
kevaundray
commented
Apr 9, 2025
Cargo.toml
Outdated
Comment on lines
692
to
713
| alloy-consensus = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-contract = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-eips = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-genesis = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-json-rpc = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-network = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-network-primitives = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-node-bindings = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-provider = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-pubsub = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-client = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-admin = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-anvil = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-beacon = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-debug = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-engine = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-eth = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-mev = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-trace = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-rpc-types-txpool = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } | ||
| alloy-serde = { git = "https://github.com/alloy-rs/alloy", rev = "997e211" } |
kevaundray
commented
Apr 9, 2025
kevaundray
changed the title
headers field in the ExecutionWitness when calling debug_executionWitness
mattsse
reviewed
Apr 9, 2025
| state, | ||
| codes: Default::default(), | ||
| keys: state_preimages, | ||
| headers: Vec::new(), |
There was a problem hiding this comment.
fyi @yash-atreya to keep the alloy bump pr simple, we can simply ini this with default and then send this pr as followup right away
Merged
rkrasiuk
approved these changes
Apr 11, 2025
mattsse
approved these changes
Apr 11, 2025
07Vaishnavi-Singh
pushed a commit
to 07Vaishnavi-Singh/reth
that referenced
this pull request
May 3, 2025
…alling `debug_executionWitness` (paradigmxyz#15608) Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies reth to populate the ancestor headers in the ExecutionWitness field. This field was added in this alloy PR