Skip to content

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Apr 22, 2025

cargo update is ran weekly however it keeps updating crunchy from 0.2.2 to 0.2.3 even though it should not.

I have not checked the reason for this overriding -- just putting up this PR as a quick hotfix, so that we don't need to do it manually each time.

@kevaundray
Copy link
Contributor Author

Tested here using a workflow dispatch

@kevaundray
Copy link
Contributor Author

Leaving this in draft incase its not wanted -- it essentially only saves you one extra commit per week

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see how this goes,
tired of doing this manually -.-

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Apr 22, 2025
@mattsse mattsse marked this pull request as ready for review April 22, 2025 15:12
@mattsse mattsse added the A-ci Related to github workflows or other build and lint tools label Apr 22, 2025
@mattsse mattsse added this pull request to the merge queue Apr 22, 2025
Merged via the queue into paradigmxyz:main with commit 23cc8f7 Apr 22, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Apr 22, 2025
@DaniPopes
Copy link
Member

This is not the right fix. This pin is present in the root Cargo.toml:

reth/Cargo.toml

Lines 645 to 649 in 76633a5

# TODO: When we build for a windows target on an ubuntu runner, crunchy tries to
# get the wrong path, update this when the workflow has been updated
#
# See: https://github.com/eira-fransham/crunchy/issues/13
crunchy = "=0.2.2"
, but it's not included in any of the crates, so it's not applied. Please revert this and add it to one of the workspace crates.

@kevaundray
Copy link
Contributor Author

This is not the right fix. This pin is present in the root Cargo.toml:

reth/Cargo.toml

Lines 645 to 649 in 76633a5

# TODO: When we build for a windows target on an ubuntu runner, crunchy tries to
# get the wrong path, update this when the workflow has been updated
#
# See: https://github.com/eira-fransham/crunchy/issues/13
crunchy = "=0.2.2"

, but it's not included in any of the crates, so it's not applied. Please revert this and add it to one of the workspace crates.

Will revert and check -- I had always assumed that the workspace crate would be respected

07Vaishnavi-Singh pushed a commit to 07Vaishnavi-Singh/reth that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Related to github workflows or other build and lint tools

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants