websocket: add transactionReceipts for receipts notification #18850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10gic
requested review from
Rjected,
RomanHodulak,
gakonst and
mattsse
as code owners
|
This PR depends on alloy-rs/alloy#2974. |
|
Hi @mattsse @Rjected @RomanHodulak @gakonst, Friendly ping on this PR! This feature has been implemented in Geth, so thought it might be helpful to get it into Reth as well. Would appreciate your review when you get a chance. Thanks! |
|
@mattsse Just following up on my PR from two weeks ago. I see that the dependency PR alloy-rs/alloy#2974 LGTM. Would you have a chance to take a look when you get a moment? |
|
@10gic I keep this open because this already integrates the new variant which will become useful later I will rebase once we have it released, after the next reth version |
mattsse
added
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can get transaction receipts from the HTTP API eth_getTransactionReceipt. In this PR, I add support for getting transaction receipts from the WebSocket API: Add a new subscription_name: transactionReceipts, which accepts an optional transaction hashes filter.
For more information, see: ethereum/go-ethereum#32697