Skip to content

fix: prevent TransactionLookup::prune from panicking #20163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayWhite2357 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent TransactionLookup::prune from panicking #20163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/prune/prune/src/segments/user/transaction_lookup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,14 @@ where
}
}
.into_inner();
let tx_range = start..=
Some(end)
.min(input.limiter.deleted_entries_limit_left().map(|left| start + left as u64 - 1))
let tx_range = start
..=Some(end)
.min(
input
.limiter
.deleted_entries_limit_left()
.map(|left| start.wrapping_add(left as u64).wrapping_sub(1)),
Copy link
Collaborator

@mattsse mattsse Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be saturating add

@joshieDo @shekhirin

)
.unwrap();
let tx_range_end = *tx_range.end();

Expand Down