Skip to content

chore: add missing EMPTY_ROOT_HASH warning for prehashed validation #20178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fallengirl wants to merge 1 commit into from
+6 −0
Closed

chore: add missing EMPTY_ROOT_HASH warning for prehashed validation #20178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/optimism/consensus/src/validation/isthmus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ where
let storage_root = withdrawals_root_prehashed(hashed_storage_updates, state)
.map_err(OpConsensusError::L2WithdrawalsRootCalculationFail)?;

if storage_root == EMPTY_ROOT_HASH {
// if there was no MessagePasser contract storage, something is wrong
// (it should at least store an implementation address and owner address)
warn!("isthmus: no storage root for L2ToL1MessagePasser contract");
}

if header_storage_root != storage_root {
return Err(OpConsensusError::L2WithdrawalsRootMismatch {
header: header_storage_root,
Expand Down
Loading