feat(js/tracing): invoke js's step inside step_end#220
Open
jsvisa wants to merge 4 commits intoparadigmxyz:mainfrom
Open
feat(js/tracing): invoke js's step inside step_end#220jsvisa wants to merge 4 commits intoparadigmxyz:mainfrom
jsvisa wants to merge 4 commits intoparadigmxyz:mainfrom
Conversation
jsvisa
force-pushed
the
js-gasCost-step
branch
from
6231d8a to
e7a379f
Compare
jsvisa
force-pushed
the
js-gasCost-step
branch
2 times, most recently
from
6a4d9f5 to
f8b0ece
Compare
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
force-pushed
the
js-gasCost-step
branch
from
f8b0ece to
814831d
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #200 with the following adjusts:
step_fnfromstepintostep_end;step;waiting for #222 and bluealloy/revm#1820 to be merged first.
but failed with below issues: stake/memory related JS functions maybe failed.Because we're invokingstep_fn.callin step_end, seems the stack and memory are messed up, so if we try to call those functions inside JS'sstep(eg:log.stack.peek(0)) the JS binding will be failed, maybe it's caused by theJsInspector::Context, but asboe_engine::Contextdoesn't implemated Copy, we can't store thestep's Contextas the environment to used in thestep_end