feat(mux-tracer): Support JS tracer in MUX tracer.#291
Open
kustrun wants to merge 1 commit intoparadigmxyz:mainfrom
Open
feat(mux-tracer): Support JS tracer in MUX tracer.#291kustrun wants to merge 1 commit intoparadigmxyz:mainfrom
kustrun wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
kustrun
force-pushed
the
feat/support-js-tracer-in-mux-tracer
branch
from
9351f18 to
f0f15f7
Compare
mattsse
requested changes
May 13, 2025
Contributor
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
cool,
for testing you can patch the alloy deps to you branch
I'd still like to keep mux support without the json feature so we need sprinkle some features across this file
src/tracing/mux.rs
Outdated
| /// Mux tracing inspector that runs and collects results of multiple inspectors at once. | ||
| #[derive(Clone, Debug)] | ||
| #[derive(Debug)] | ||
| #[cfg(feature = "js-tracer")] |
Contributor
There was a problem hiding this comment.
since the fields are private we can simply feature gate the addiiotnal jsInspector here
Author
|
@mattsse As suggested, I have added the conditional support for JS tracer in MUX tracer. |
mattsse
force-pushed
the
feat/support-js-tracer-in-mux-tracer
branch
from
a203c39 to
dc890ee
Compare
Adds support for JS tracers in the MuxInspector: - Add `code` field and `code()` method to JsInspector to retrieve the JS code - Change `json_result` and `result` to take a reference to ResultAndState - Add `js_tracer` field to MuxInspector (feature-gated behind js-tracer) - Add `MuxConfigExt` type for extended configuration with JS tracers - Add `try_from_config_ext` and `try_into_mux_frame_ext` methods for JS tracer support - Add JS tracer calls to all Inspector trait methods in MuxInspector Closes paradigmxyz#58
mattsse
force-pushed
the
feat/support-js-tracer-in-mux-tracer
branch
from
dc890ee to
3480e55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #58
Motivation
Currently
muxTracersupports only built-in tracers. It should also supportJS tracers.Dependent on: alloy-rs/alloy#2442