feat(mux-tracer): Support JS tracer in MUX tracer. #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustrun
force-pushed
the
feat/support-js-tracer-in-mux-tracer
branch
from
9351f18 to
f0f15f7
Compare
mattsse
requested changes
May 13, 2025
src/tracing/mux.rs
Outdated
| /// Mux tracing inspector that runs and collects results of multiple inspectors at once. | ||
| #[derive(Clone, Debug)] | ||
| #[derive(Debug)] | ||
| #[cfg(feature = "js-tracer")] |
There was a problem hiding this comment.
since the fields are private we can simply feature gate the addiiotnal jsInspector here
… Tracer can be used with / without it.
|
@mattsse As suggested, I have added the conditional support for JS tracer in MUX tracer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #58
Motivation
Currently
muxTracersupports only built-in tracers. It should also supportJS tracers.Dependent on: alloy-rs/alloy#2442