-
Notifications
You must be signed in to change notification settings - Fork 87
Feat/pkcs11 3.0 #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/pkcs11 3.0 #228
Conversation
9c3460b to
462c07b
Compare
hug-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Excellent as well if this is compatible with 2.4. A few general comments but I am okay otherwise with it!
f80dbf0 to
54ee6ab
Compare
hug-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to resolve the last comment, if it's not something you were planning to investigate. I think it's fine to go as it is, and I can open an issue for this specific item to be looked at later :)
I think it's mainly because There are some issues mentioning
Do you want me to open up a new issue? |
|
@hug-dev also what do you suggest to do with the misspelling in the new header.. |
Signed-off-by: Direktor799 <[email protected]>
Signed-off-by: Direktor799 <[email protected]>
Signed-off-by: Direktor799 <[email protected]>
Signed-off-by: Direktor799 <[email protected]>
7804490 to
3e2656e
Compare
Signed-off-by: Direktor799 <[email protected]>
3e2656e to
1eb78c5
Compare
wiktor-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Replace
pkcs11.hwith https://github.com/latchset/pkcs11-headers/blob/main/public-domain/3.0/pkcs11.h, which was mentioned in #156.CK_UNAVAILABLE_INFORMATIONdue to a bug(i believe) inbindgenPKCS11_DEPRECATEDfor backward compatibility with 2.4EC_NAMEDCURVE, replace it withEC_OID