Skip to content

Conversation

@wiktor-k
Copy link
Collaborator

The old root module documentation referred to the unused "new" module. This PR cleans up the docs a bit and adds code example which gets executed as part of the unit tests.

ionut-arm
ionut-arm previously approved these changes Oct 30, 2024
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Added a suggestion to have an examples folder

hug-dev
hug-dev previously approved these changes Oct 30, 2024
@wiktor-k wiktor-k dismissed stale reviews from hug-dev and ionut-arm via 5194772 October 31, 2024 10:06
@wiktor-k wiktor-k force-pushed the wiktor/better-readme branch from f4199d3 to 5194772 Compare October 31, 2024 10:06
@hug-dev hug-dev enabled auto-merge November 12, 2024 12:38
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hug-dev hug-dev merged commit 7d5cccd into parallaxsecond:main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants