Add support for Pkcs#11 Profile objects #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
wiktor-k
reviewed
Sep 3, 2025
Collaborator
wiktor-k
left a comment
wiktor-k
left a comment
There was a problem hiding this comment.
Looks good in general, a couple of nits if you don't mind :)
Jakuje
force-pushed
the
pkcs11-profile
branch
from
aba414c to
ed32cb4
Compare
Signed-off-by: Jakub Jelen <[email protected]>
error: hiding a lifetime that's elided elsewhere is confusing
--> cryptoki/src/session/object_management.rs:227:25
|
227 | pub fn iter_objects(&self, template: &[Attribute]) -> Result<ObjectHandleIterator> {
| ^^^^^ the lifetime is elided here -------------------- the same lifetime is hidden here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `-D mismatched-lifetime-syntaxes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(mismatched_lifetime_syntaxes)]`
help: use `'_` for type paths
|
227 | pub fn iter_objects(&self, template: &[Attribute]) -> Result<ObjectHandleIterator<'_>> {
| ++++
Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
force-pushed
the
pkcs11-profile
branch
from
ed32cb4 to
57b79fc
Compare
hug-dev
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows selecting new object types, profiles, from the token and reading their attributes, consisting of a profile ID the token implements:
https://docs.oasis-open.org/pkcs11/pkcs11-profiles/v3.1/os/pkcs11-profiles-v3.1-os.html
The specs is a bit vague and my understanding is that the profiles can overlap, but are not always superset of some other profile, which makes me thinking the token can have several profile objects.
Currently, this is not implemented by neither kryoptic nor softhsm, but I filled a RFE for kryoptic (latchset/kryoptic#305) so once we will have it in, I will try to write some test.