Run tests against kryoptic main #328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Jelen <[email protected]>
Fixes: parallaxsecond#311 Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
force-pushed
the
kryoptic-main
branch
from
6abd032 to
f17e54f
Compare
wiktor-k
approved these changes
Nov 27, 2025
Collaborator
wiktor-k
left a comment
wiktor-k
left a comment
There was a problem hiding this comment.
I think this looks good 👌
| OUT_DIR: /__w/rust-cryptoki/kryoptic/target/debug/deps/ | ||
| RUST_BACKTRACE: 1 | ||
| run: cargo test | ||
| run: cargo build --all-features && cargo test |
Collaborator
There was a problem hiding this comment.
I think check is enough, since we don't care about the output artifacts:
Suggested change
| run: cargo build --all-features && cargo test | |
| run: cargo check --all-features && cargo test |
The question is whether we want to check --all-targets (which include tests and examples and bins...)...
Collaborator
Author
There was a problem hiding this comment.
I took this from ci.yml (where I probably wrote this previously). I think that just test should be enough. Not sure if we should need the check at all here as the check is executed in the other jobs (as well as the --all-targets -- the Fedora cargo should not be that much different from ubuntu cargo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #311 and discussion in #326, where we agreed that keeping track of main is less problematic than keeping outdated version.