Add no-std and baremetal features#133
Conversation
ea9f07f to
2e08c80
Compare
|
Adding a baremetal and a no_std feature is contrary to the addititvity of Cargo features. If there is an actual need for std (for #131 I don't think we need an extra feature, it can be no_std and no_alloc all the time), and it's on by default now, it should become a default feature "std", so that all dependencies that are themselves no_std would use this with no-default-features, but as soon as any dependent crate needs std, std is in. |
Manual copy of changes done in: https://github.com/malishav/rust-psa-crypto/tree/baremetal Signed-off-by: Geovane Fedrecheski <geonnave@gmail.com>
2e08c80 to
4d51c5d
Compare
|
Thanks for the feedback @chrysn. Before I spend more time on this, I would like to hear what the maintainers think of addressing this issue. |
|
Hi! Thanks for the patch, it looks good to me. In my opinion, making it I wanted to ask whether it would be possible/make sense to enable it for Also, the one thing I'd like added is some mention in the README about the new features. :) |
Signed-off-by: Geovane Fedrecheski <geonnave@gmail.com>
e2a6872 to
79ad9ee
Compare
|
Thank you @ionut-arm. Regarding In addition, I realized I need some extra build flags to be passed to |
|
With #145 this crate should be no_std! |
This is an ongoing attempt at addressing #131. Heavily based on this fork. cc @chrysn @malishav