Skip to content

Conversation

@Firstyear
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need to update the lock file as well?

@ionut-arm
Copy link
Member

I wonder if we need to update the lock file as well?

That was my thought as well. I regret not putting in the effort to write a script to update that file automatically from the current Cargo.lock.... So find a short script for that below.

#!/bin/bash

export MSRV=1.66.0
export EXEC_DIR="tss-esapi"

if [[ "$(basename `pwd`)" != "$EXEC_DIR" ]]; then
        echo "Script should be run from ./$EXEC_DIR ."
        exit 1
fi

rustup toolchain install $MSRV
cargo +$MSRV build
cp ../Cargo.lock tests/Cargo.lock.frozen

Also, find attached the regenerated lockfile for this change.
Cargo.lock.frozen.zip

@Firstyear
Copy link
Collaborator Author

Okay, so I'll update the Cargo.lock as well in that case? Are there other concerns?

@ionut-arm
Copy link
Member

Okay, so I'll update the Cargo.lock as well in that case? Are there other concerns?

Sounds like a plan, if you have time for it!

@Firstyear Firstyear force-pushed the 20240403-update-deps branch from 3597f30 to 0b91435 Compare April 23, 2024 00:38
@Firstyear
Copy link
Collaborator Author

Done, Cargo.lock updated.

@Superhepper
Copy link
Collaborator

Superhepper commented Sep 25, 2024

This has been fixed in another PR. #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants