Skip to content

Conversation

@brandsimon
Copy link
Contributor

@brandsimon brandsimon commented Mar 31, 2025

When there is an error fetching the script and the result is empty, bash does not complain.
The result is a broken image.

Signed-off-by: Simon Brand <[email protected]>
When there is an error fetching the script and the result is empty, bash does not complain. The result is an undetected broken image.

Signed-off-by: Simon Brand <[email protected]>
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we aren't using rust official images in the first place but a 5 year old thing 🤔

But that's a separate matter 😅

Thanks for fixing!

@brandsimon
Copy link
Contributor Author

I think we use the tpm2-software/ubuntu-20.04 image, because it is more difficult to install the tpm2 stuff then it is to install the rust stuff. (Also there are a lot of manual tss2 setup commands)

@brandsimon brandsimon closed this Apr 12, 2025
@brandsimon brandsimon deleted the sbr/minor_fixes branch April 12, 2025 09:50
@brandsimon brandsimon restored the sbr/minor_fixes branch April 12, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants