rework TryFrom converting signatures to accept a ref #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
reviewed
Apr 10, 2025
| type Error = Error; | ||
|
|
||
| fn try_from(signature: EccSignature) -> Result<Self> { | ||
| fn try_from(signature: &EccSignature) -> Result<Self> { |
There was a problem hiding this comment.
I guess this is fine because FieldBytes does not seem to be able to contain references. The only thing I would change would perhaps to use
FieldBytes::<C>::clone_from_slice()
baloo
force-pushed
the
baloo/signature/try-from-ref
branch
from
4e7ec40 to
5cc3c02
Compare
This also introduce an implementation for transforming a generic signature to an ecdsa signature. Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/signature/try-from-ref
branch
from
5cc3c02 to
bfb3123
Compare
Superhepper
approved these changes
Apr 16, 2025
wiktor-k
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduce an implementation for transforming a generic signature to an ecdsa signature.