Skip to content

Fix clippy issues #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Fix clippy issues #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions tss-esapi/src/attributes/nv_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_pp_write(mut self, set: bool) -> Self {
self.nv_index_attributes.set_pp_write(set);
self
Expand All @@ -167,7 +167,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_owner_write(mut self, set: bool) -> Self {
self.nv_index_attributes.set_owner_write(set);
self
Expand All @@ -177,7 +177,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_auth_write(mut self, set: bool) -> Self {
self.nv_index_attributes.set_auth_write(set);
self
Expand All @@ -187,7 +187,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_policy_write(mut self, set: bool) -> Self {
self.nv_index_attributes.set_policy_write(set);
self
Expand All @@ -206,7 +206,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_policy_delete(mut self, set: bool) -> Self {
self.nv_index_attributes.set_policy_delete(set);
self
Expand All @@ -216,7 +216,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_write_locked(mut self, set: bool) -> Self {
self.nv_index_attributes.set_write_locked(set);
self
Expand All @@ -226,7 +226,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_write_all(mut self, set: bool) -> Self {
self.nv_index_attributes.set_write_all(set);
self
Expand All @@ -236,7 +236,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_write_define(mut self, set: bool) -> Self {
self.nv_index_attributes.set_write_define(set);
self
Expand All @@ -246,7 +246,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_write_stclear(mut self, set: bool) -> Self {
self.nv_index_attributes.set_write_stclear(set);
self
Expand All @@ -256,7 +256,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_global_lock(mut self, set: bool) -> Self {
self.nv_index_attributes.set_global_lock(set);
self
Expand All @@ -266,7 +266,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_pp_read(mut self, set: bool) -> Self {
self.nv_index_attributes.set_pp_read(set);
self
Expand All @@ -276,7 +276,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_owner_read(mut self, set: bool) -> Self {
self.nv_index_attributes.set_owner_read(set);
self
Expand All @@ -286,7 +286,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_auth_read(mut self, set: bool) -> Self {
self.nv_index_attributes.set_auth_read(set);
self
Expand All @@ -296,7 +296,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_policy_read(mut self, set: bool) -> Self {
self.nv_index_attributes.set_policy_read(set);
self
Expand All @@ -306,7 +306,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_no_da(mut self, set: bool) -> Self {
self.nv_index_attributes.set_no_da(set);
self
Expand All @@ -316,7 +316,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_orderly(mut self, set: bool) -> Self {
self.nv_index_attributes.set_orderly(set);
self
Expand All @@ -326,7 +326,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_clear_stclear(mut self, set: bool) -> Self {
self.nv_index_attributes.set_clear_stclear(set);
self
Expand All @@ -336,7 +336,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_read_locked(mut self, set: bool) -> Self {
self.nv_index_attributes.set_read_locked(set);
self
Expand All @@ -346,7 +346,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_written(mut self, set: bool) -> Self {
self.nv_index_attributes.set_written(set);
self
Expand All @@ -356,7 +356,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_platform_create(mut self, set: bool) -> Self {
self.nv_index_attributes.set_platform_create(set);
self
Expand All @@ -366,7 +366,7 @@ impl NvIndexAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_read_stclear(mut self, set: bool) -> Self {
self.nv_index_attributes.set_read_stclear(set);
self
Expand Down
24 changes: 12 additions & 12 deletions tss-esapi/src/attributes/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_fixed_tpm(mut self, set: bool) -> Self {
self.object_attributes.set_fixed_tpm(set);
self
Expand All @@ -105,7 +105,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_st_clear(mut self, set: bool) -> Self {
self.object_attributes.set_st_clear(set);
self
Expand All @@ -115,7 +115,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_fixed_parent(mut self, set: bool) -> Self {
self.object_attributes.set_fixed_parent(set);
self
Expand All @@ -125,7 +125,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_sensitive_data_origin(mut self, set: bool) -> Self {
self.object_attributes.set_sensitive_data_origin(set);
self
Expand All @@ -135,7 +135,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_user_with_auth(mut self, set: bool) -> Self {
self.object_attributes.set_user_with_auth(set);
self
Expand All @@ -145,7 +145,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_admin_with_policy(mut self, set: bool) -> Self {
self.object_attributes.set_admin_with_policy(set);
self
Expand All @@ -155,7 +155,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_no_da(mut self, set: bool) -> Self {
self.object_attributes.set_no_da(set);
self
Expand All @@ -165,7 +165,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_encrypted_duplication(mut self, set: bool) -> Self {
self.object_attributes.set_encrypted_duplication(set);
self
Expand All @@ -175,7 +175,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_restricted(mut self, set: bool) -> Self {
self.object_attributes.set_restricted(set);
self
Expand All @@ -185,7 +185,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_decrypt(mut self, set: bool) -> Self {
self.object_attributes.set_decrypt(set);
self
Expand All @@ -195,7 +195,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_sign_encrypt(mut self, set: bool) -> Self {
self.object_attributes.set_sign_encrypt(set);
self
Expand All @@ -205,7 +205,7 @@ impl ObjectAttributesBuilder {
///
/// # Arguments
/// * `set` - `true` indicates that the attribute should have the value SET.
/// `false`indicates that the attribute should have the value CLEAR.
/// `false`indicates that the attribute should have the value CLEAR.
pub fn with_x509_sign(mut self, set: bool) -> Self {
self.object_attributes.set_x509_sign(set);
self
Expand Down
6 changes: 3 additions & 3 deletions tss-esapi/src/context/general_esys_tr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ impl Context {
///
/// # Arguments
/// * `tpm_handle` - The TPM handle that references the TPM object for which
/// the ESYS object is being created.
/// the ESYS object is being created.
///
/// # Returns
/// A handle to the ESYS object that was created from a TPM resource.
Expand Down Expand Up @@ -277,7 +277,7 @@ impl Context {
///
/// # Arguments
/// * object_handle`- An [ObjectHandle] referring to an object for which all metadata and
/// resources is going to be released.
/// resources is going to be released.
///
/// # Example
/// ```rust
Expand Down Expand Up @@ -468,7 +468,7 @@ impl Context {
///
/// # Arguments
/// * `buffer` - The buffer containing the data to restore the object.
/// It can be created using [`tr_serialize`](Self::tr_serialize).
/// It can be created using [`tr_serialize`](Self::tr_serialize).
///
/// # Returns
/// A handle to the object that was created from the buffer.
Expand Down
4 changes: 2 additions & 2 deletions tss-esapi/src/context/tpm_commands/asymmetric_primitives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl Context {
///
/// # Arguments
/// * `key_handle`- A [KeyHandle] of ECC key which curve parameters will be used
/// to generate the ephemeral key.
/// to generate the ephemeral key.
///
/// # Details
/// This command uses the TPM to generate an ephemeral
Expand Down Expand Up @@ -211,7 +211,7 @@ impl Context {
///
/// # Arguments
/// * `key_handle` - A [KeyHandle] of ECC key which curve parameters will be used
/// to generate the ephemeral key.
/// to generate the ephemeral key.
/// * `in_point` - An [EccPoint] on the curve of the key referenced by `key_handle`
///
/// # Details
Expand Down
9 changes: 4 additions & 5 deletions tss-esapi/src/context/tpm_commands/context_management.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,12 @@ impl Context {
///
/// # Arguments
/// * `auth` - An a handle used for authorization that is limited to the ones
/// specified in [Provision].
/// specified in [Provision].
/// * `object_handle` - The handle of a loaded object.
/// * `persistent` - If the `object_handle` is transient object then this
/// then this will become the persistent handle of that
/// object. If the `object_handle` refers to a persistent
/// object then this shall be the persistent handle of that
/// object.
/// then this will become the persistent handle of that object. If the
/// `object_handle` refers to a persistent object then this shall be the
/// persistent handle of that object.
///
/// # Returns
/// If the input `object_handle` was transient object then it will be made
Expand Down
4 changes: 2 additions & 2 deletions tss-esapi/src/context/tpm_commands/duplication_commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ impl Context {
/// * `object_to_duplicate` - An [ObjectHandle] of the object that will be duplicated.
/// * `new_parent_handle` - An [ObjectHandle] of the new parent.
/// * `encryption_key_in` - An optional encryption key. If this parameter is `None`
/// then a [default value][Default::default] is used.
/// then a [default value][Default::default] is used.
/// * `symmetric_alg` - Symmetric algorithm to be used for the inner wrapper.
///
/// The `object_to_duplicate` need to be have Fixed TPM and Fixed Parent attributes set to `false`.
Expand Down Expand Up @@ -347,7 +347,7 @@ impl Context {
/// # Arguments
/// * `parent_handle` - An [ObjectHandle] of the new parent for the object.
/// * `encryption_key` - An optional symmetric encryption key used as the inner wrapper.
/// If `encryption_key` is `None` then a [default value][Default::default] is used.
/// If `encryption_key` is `None` then a [default value][Default::default] is used.
/// * `public` - A [Public] of the imported object.
/// * `duplicate` - A symmetrically encrypted duplicated object.
/// * `encrypted_secret` - The seed for the symmetric key and HMAC key.
Expand Down
4 changes: 2 additions & 2 deletions tss-esapi/src/context/tpm_commands/enhanced_authorization_ea_commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ impl Context {
/// * `object_name` - The [name][Name] of the object being duplicated.
/// * `new_parent_name` - The [name][Name] of the new parent.
/// * `include_object` - Flag indicating if `object_name` will be included in policy
/// calculation.
/// calculation.
///
/// # Details
/// Set `include_object` only when this command is used in conjunction with
Expand Down Expand Up @@ -601,7 +601,7 @@ impl Context {
/// * `policy_session` - The [policy session][PolicySession] being extended.
/// * `auth_handle` - Handle indicating the source of authorization value.
/// * `nv_index_handle` - The [NvIndexHandle] associated with NV memory
/// where the policy is stored.
/// where the policy is stored.
///
/// # Example
/// ```rust
Expand Down
Loading