Add github action for CI (lint, check format, build)#53
Add github action for CI (lint, check format, build)#53lyonsil merged 5 commits intoparanext:mainfrom
Conversation
* Also clean-up some README.md markdown best practice violations
b97ab12 to
18150fb
Compare
18150fb to
d47f575
Compare
lyonsil
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have one thing in the GH workflow file, and the rest looks great.
Reviewed 1 of 2 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @jasonleenaylor)
.github/workflows/build.yml line 36 at r3 (raw file):
build doesn't actually do anything in the template. It's kind of confusing that it's here in this workflow, and the output from the job just says:
Run npm run build
> paranext-multi-extension-template@0.0.1 build
> webpack
No extensions found! Please run `npm run create-extension -- <extension-name>` (kebab-case) to create an extension. See README.md for more information.
What are you trying to catch with this step? It might be a little clearer to:
- remove this build step
- change the job name from "lint-and-build" to "lint"
- change this GH workflow file from "build.yml" to "lint.yml"
- change the OS matrix to only be
ubuntu-latestsince linting doesn't vary by OS
|
Previously, lyonsil (Matt Lyons) wrote…
Ah yeah, I originally was going to have it call create-extension and build but I thought that was overkill. Should have thought through what build actually did without that. 🤦♂️ |
lyonsil
left a comment
There was a problem hiding this comment.
Please make sure to squash this when merging.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @jasonleenaylor)
.github/workflows/build.yml line 36 at r3 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Ah yeah, I originally was going to have it call create-extension and build but I thought that was overkill. Should have thought through what build actually did without that. 🤦♂️
Thanks for the update!
lyonsil
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jasonleenaylor)
tjcouch-sil
left a comment
There was a problem hiding this comment.
Jason, would you be interested in duplicating this on the
paranext-extension-template repo as well? Or shall someone else plan to do that? Thanks for this good stuff!
Reviewed 1 of 2 files at r1, 1 of 2 files at r2, 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)
This change is