Skip to content

Eslint naming convention#81

Merged
irahopkinson merged 1 commit intomainfrom
eslint-names
Mar 12, 2026
Merged

Eslint naming convention#81
irahopkinson merged 1 commit intomainfrom
eslint-names

Conversation

@irahopkinson
Copy link
Copy Markdown
Contributor

@irahopkinson irahopkinson commented Mar 11, 2026

  • PR #550 suggested a lint check for type naming conventions

This change is Reviewable

- PR #550 suggested a lint check for type naming conventions
@irahopkinson irahopkinson enabled auto-merge (squash) March 11, 2026 05:04
Copy link
Copy Markdown
Contributor

@tombogle tombogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombogle reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on lyonsil and tjcouch-sil).

Copy link
Copy Markdown
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks! Just one thing to figure out from the core PR before merging

@tjcouch-sil reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on irahopkinson and lyonsil).


.eslintrc.cjs line 80 at r1 (raw file):

        format: ['PascalCase'],
      },
    ],

Waiting on discussion in core https://reviewable.io/reviews/paranext/paranext-core/2100#-OnSE7SI086jp2BCzlS5

Copy link
Copy Markdown
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks

@tjcouch-sil made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on lyonsil).

@irahopkinson irahopkinson merged commit 1fa09bb into main Mar 12, 2026
5 checks passed
@irahopkinson irahopkinson deleted the eslint-names branch March 12, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants