Fix QEMU distro tests, switch to hash spec_id map and remove pid based attachment #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on more amd64 kernels.
multi-attach support but it seems to work fine even without it. this is verified with better kernel version testing. Separate bpf_get_attach cookie and use multi-probe features. cookies can in 5.15 and multi came 6.6. Use HASH for usdt spec map instead of ARRAY. ARRAY entires can't be deleted and map fills up over time.
gnurizen
changed the title
umanwizard
approved these changes
Dec 15, 2025
| ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) | ||
| defer cancel() | ||
|
|
||
| // Start the tracer with all tracers enabled |
Collaborator
There was a problem hiding this comment.
this comment needs to be updated
Comment on lines
+105
to
+107
| else | ||
| CGO_ENABLED=1 GOARCH=${GOARCH} go test -c ../../interpreter/rtld ../../support/usdt/test | ||
| fi |
Collaborator
There was a problem hiding this comment.
Can you check if the arch is x86 here and fail otherwise? I want to limit introducing new cases where we assume the only arches in the world are arm and x86 (because that will make it easier to support riscv in the future)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.