Merged
Conversation
umanwizard
reviewed
Mar 4, 2026
Comment on lines
-794
to
-795
| // this is used by userland to stash the kernel name pointer | ||
| data[1] = 0; |
Collaborator
There was a problem hiding this comment.
Why don't we need this? Somewhere in user-space there is a call to SetVariable that relies on space being there for this, isn't there?
Collaborator
There was a problem hiding this comment.
NVM, apparently that has gone away at some point.
Collaborator
Author
There was a problem hiding this comment.
All that's needed is the correlation id, the kernel name is stored in libpf.Frame.FunctionName in gpu.prepTrace which comes from the kernel timing info and not the original trace.
Collaborator
Author
There was a problem hiding this comment.
I don't see any calls to SetVariable anywhere
Collaborator
Author
There was a problem hiding this comment.
Ah it doesn't exist upstream, I think we can remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.