Shorten DEBUG_PRINT strings to pass BPF verifier on kernel 6.1.91#225
Open
gnurizen wants to merge 1 commit intobtv/mergesfrom
Open
Shorten DEBUG_PRINT strings to pass BPF verifier on kernel 6.1.91#225gnurizen wants to merge 1 commit intobtv/mergesfrom
gnurizen wants to merge 1 commit intobtv/mergesfrom
Conversation
This unwinder is pretty close to the limit and a big factor is DEBUG_PRINT statements b/c we're using the old model where the fmt must be copied to the stack in 8 byte chunks. Stay under the limit by shrinking print statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aggressively abbreviate DEBUG_PRINT format strings across the python
unwinder path to reduce BPF instruction count. Comment out one
DEBUG_PRINT ("null codeobject") that pushes the verifier over its
1M instruction processing limit. Move increment_metric for
UNWIND_COMMAND_STOP into unwind_one_frame to keep it near related
logic after removing it from get_stack_delta.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com