Open
Conversation
gnurizen
reviewed
Mar 10, 2026
gnurizen
approved these changes
Mar 10, 2026
umanwizard
reviewed
Mar 10, 2026
gnurizen
reviewed
Mar 12, 2026
| func extractDebugIDFromFile(pid libpf.PID, filePath string) libpf.FileID { | ||
| filePath = strings.TrimPrefix(filePath, "file://") | ||
| containerPath := fmt.Sprintf("/proc/%d/root%s", pid, filePath) | ||
| containerPath := filepath.Join(fmt.Sprintf("/proc/%d/root", pid), filePath) |
Collaborator
There was a problem hiding this comment.
containerPath := filepath.Join("/proc", strconv.Itoa(pid), "root", filePath)
might be more idiomatic and performant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes the already approved PR #179, that was created before the upstream sync.
This PR implements the extraction of the debugId from the magic comment of the js file and passing that as part of the
framedata, so that this can be used to source map thelocationson the server.