Make custom labels support 4.19 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnurizen
force-pushed
the
cus-lab-exp
branch
3 times, most recently
from
fc66810 to
cb72e77
Compare
gnurizen
changed the title
gnurizen
force-pushed
the
cus-lab-exp
branch
4 times, most recently
from
b538aa3 to
2cf00bd
Compare
gnurizen
force-pushed
the
cus-lab-exp
branch
from
2cf00bd to
f5fd482
Compare
gnurizen
changed the title
gnurizen
force-pushed
the
cus-lab-exp
branch
6 times, most recently
from
67b57f7 to
f713453
Compare
gnurizen
force-pushed
the
cus-lab-exp
branch
2 times, most recently
from
ac9d6d8 to
2a4ad41
Compare
umanwizard
approved these changes
Feb 20, 2025
Collaborator
umanwizard
left a comment
umanwizard
left a comment
There was a problem hiding this comment.
LGTM, and super cool that we were able to get rid of that opaquify crap and dodgy inline asm.
support/ebpf/go_labels.ebpf.c
Outdated
Comment on lines
2
to
3
| // the tracers, as well as a dispatcher program that can be attached to a | ||
| // perf event and will call the appropriate tracer for a given process |
Collaborator
There was a problem hiding this comment.
Erroneously copy/pasted comment?
Collaborator
Author
There was a problem hiding this comment.
Yeah, I need to fix the copy right too
Collaborator
Author
There was a problem hiding this comment.
Well I guess none of the unwinders have copyright headers so I just fixed the comment.
gnurizen
force-pushed
the
cus-lab-exp
branch
4 times, most recently
from
28b4a55 to
cec3850
Compare
Put go label collection in a separate unwinder routine and tail call it. Native unwinder and other custom labels code stays in unwind_stop. Hand unroll loops and great simplify the hash function. Reduce number of custom labels from 16 to 14. Remove opaquify.h, fix verifier errors by moving code around. Add a simple integration test for custom labels that runs against all kernels. Refactor test code to put shared code in a helper package.
gnurizen
force-pushed
the
cus-lab-exp
branch
from
cec3850 to
17cc279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.