Remove custom labels hash and write directly to Trace #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnurizen
changed the title
umanwizard
reviewed
Feb 20, 2025
| CustomLabel *lbl = &out->labels[out->len]; | ||
| if (map_value->keys[i].str != NULL) { | ||
| long res = bpf_probe_read_user(lbl->key.key_bytes, CUSTOM_LABEL_MAX_KEY_LEN, map_value->keys[i].str); | ||
| unsigned klen = MIN(map_value->keys[i].len, CUSTOM_LABEL_MAX_KEY_LEN-1); |
Collaborator
Author
There was a problem hiding this comment.
Since I removed the len I need to leave a character for the null terminator.
umanwizard
approved these changes
Feb 21, 2025
gnurizen
force-pushed
the
rem-hash
branch
2 times, most recently
from
07fd31d to
4fc9887
Compare
Put go label collection in a separate unwinder routine and tail call it. Native unwinder and other custom labels code stays in unwind_stop. Hand unroll loops and great simplify the hash function. Reduce number of custom labels from 16 to 14. Remove opaquify.h, fix verifier errors by moving code around. Add a simple integration test for custom labels that runs against all kernels. Refactor test code to put shared code in a helper package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves 2MB of map memory.
Make labels key length 16 instead of 64 bytes. Make value length 48
instead of 64. Make max custom labels 10. This keeps space added
to trace structure to 640 bytes.
Don't store key/value length, just copy MAX-1 bytes and rely on things
being null terminated.