Skip to content

Conversation

@dreamerlzl
Copy link
Contributor

@dreamerlzl dreamerlzl commented Jun 25, 2025

see #3019

@brancz
Copy link
Member

brancz commented Jul 8, 2025

If I recall correctly I think we had this cache in the old agent because we wanted to re-resolve metadata every now and then, eg. if an annotation was added to a pod at runtime. I feel like a 15s TTL might be a little too aggressive for this though. I think maybe a 10min TTL is more appropriate as this should really only be necessary quite rarely.

@dreamerlzl
Copy link
Contributor Author

If I recall correctly I think we had this cache in the old agent because we wanted to re-resolve metadata every now and then, eg. if an annotation was added to a pod at runtime. I feel like a 15s TTL might be a little too aggressive for this though. I think maybe a 10min TTL is more appropriate as this should really only be necessary quite rarely.

Yeah we have the similar use cases. I have changed the default value to 10min

@brancz brancz merged commit 4740e14 into parca-dev:main Jul 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants