Skip to content

Add sample_writes_total metric to track written sample records #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brancz merged 1 commit into from
Oct 6, 2025
Merged

Add sample_writes_total metric to track written sample records #3103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions reporter/parca_reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ import (
lru "github.com/elastic/go-freelru"
"github.com/klauspost/compress/zstd"
"github.com/parca-dev/oomprof/oomprof"
"github.com/parca-dev/parca-agent/metrics"
"github.com/parca-dev/parca-agent/reporter/metadata"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/common/model"
"github.com/prometheus/prometheus/model/labels"
Expand All @@ -46,6 +44,9 @@ import (
"go.opentelemetry.io/ebpf-profiler/reporter"
"go.opentelemetry.io/ebpf-profiler/reporter/samples"
"go.opentelemetry.io/ebpf-profiler/support"

"github.com/parca-dev/parca-agent/metrics"
"github.com/parca-dev/parca-agent/reporter/metadata"
)

// Assert that we implement the full Reporter interface.
Expand Down Expand Up @@ -126,6 +127,7 @@ type ParcaReporter struct {
otelLibraryMetrics map[string]prometheus.Metric

// Our own metrics
sampleWrites prometheus.Counter
sampleWriteRequestBytes prometheus.Counter
stacktraceWriteRequestBytes prometheus.Counter
debuginfoUploadRequestBytes prometheus.Counter
Expand Down Expand Up @@ -598,6 +600,10 @@ func New(
return nil, err
}

sampleWrites := prometheus.NewCounter(prometheus.CounterOpts{
Name: "sample_writes_total",
Help: "the total number of samples written in WriteRequest calls for sample records",
})
sampleWriteRequestBytes := prometheus.NewCounter(prometheus.CounterOpts{
Name: "sample_write_request_bytes",
Help: "the total number of bytes written in WriteRequest calls for sample records",
Expand All @@ -612,6 +618,7 @@ func New(
})

reg.MustRegister(sampleWriteRequestBytes)
reg.MustRegister(sampleWrites)
reg.MustRegister(stacktraceWriteRequestBytes)
reg.MustRegister(debuginfoUploadRequestBytes)

Expand All @@ -638,6 +645,7 @@ func New(
},
reg: reg,
otelLibraryMetrics: make(map[string]prometheus.Metric),
sampleWrites: sampleWrites,
sampleWriteRequestBytes: sampleWriteRequestBytes,
stacktraceWriteRequestBytes: stacktraceWriteRequestBytes,
debuginfoUploadRequestBytes: debuginfoUploadRequestBytes,
Expand Down Expand Up @@ -934,6 +942,7 @@ func (r *ParcaReporter) logDataForOfflineMode(ctx context.Context, buf *bytes.Bu
return fmt.Errorf("Failed to write to log %s: %v", r.offlineModeLogPath, err)
}

r.sampleWrites.Add(float64(record.NumRows()))
r.sampleWriteRequestBytes.Add(float64(buf.Len()))

sidFieldIdx := nLabelCols
Expand Down Expand Up @@ -1055,6 +1064,8 @@ func (r *ParcaReporter) reportDataToBackend(ctx context.Context, buf *bytes.Buff
}); err != nil {
return err
}

r.sampleWrites.Add(float64(record.NumRows()))
r.sampleWriteRequestBytes.Add(float64(buf.Len()))

log.Debugf("Sent profile with %d samples", record.NumRows())
Expand Down