Skip to content

Sample counts by type metrics #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnurizen merged 1 commit into from
Jan 27, 2026
+21 −3
Merged

Sample counts by type metrics #3131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions reporter/parca_reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ type ParcaReporter struct {
debuginfoUploadRequestBytes prometheus.Counter
emptySamples prometheus.Counter

// Pre-created sample counters by type (avoid WithLabelValues allocations)
cpuSamples prometheus.Counter
gpuSamples prometheus.Counter
offcpuSamples prometheus.Counter
memorySamples prometheus.Counter

offlineModeConfig *OfflineModeConfig

// Protects the log file,
Expand Down Expand Up @@ -260,12 +266,12 @@ func (r *ParcaReporter) ReportTraceEvent(trace *libpf.Trace,
case support.TraceOriginSampling:
writeSample(1, time.Second.Nanoseconds(), 1e9/int64(r.samplesPerSecond), "parca_agent", "samples", "count", "cpu", "nanoseconds")
r.sampleWriter.Temporality.AppendString("delta")
r.cpuSamples.Inc()
case support.TraceOriginOffCPU:
writeSample(meta.OffTime, time.Second.Nanoseconds(), 1e9/int64(r.samplesPerSecond), "parca_agent", "wallclock", "nanoseconds", "samples", "count")
r.sampleWriter.Temporality.AppendString("delta")
r.offcpuSamples.Inc()
case support.TraceOriginMemory:
// This shouldn't happen too much so an info log is fine, revisit when we do continuous memory profiling.
log.Infof("Received memory trace event for TID %d, PID %d, comm %s", meta.TID, meta.PID, meta.Comm)
// TODO: this isn't necessarily correct and should be extracted from the Go process somehow.
memPeriod := int64(512 * 1024) // 512 KiB
// Write 4 memory samples
Expand All @@ -287,9 +293,11 @@ func (r *ParcaReporter) ReportTraceEvent(trace *libpf.Trace,
r.sampleWriter.Temporality.AppendNull()
writeSample(int64(meta.AllocBytes), 0, memPeriod, "memory", "alloc_space", "bytes", "space", "bytes")
}
r.memorySamples.Inc()
case support.TraceOriginCuda:
writeSample(meta.OffTime, time.Second.Nanoseconds(), 1e9/int64(r.samplesPerSecond), "parca_agent", "cuda", "nanoseconds", "cuda", "nanoseconds")
r.sampleWriter.Temporality.AppendString("delta")
r.gpuSamples.Inc()
}

return nil
Expand Down Expand Up @@ -629,11 +637,17 @@ func New(
Help: "The number of empty samples reported to the Parca reporter",
})

samplesByType := prometheus.NewCounterVec(prometheus.CounterOpts{
Name: "parca_reporter_samples_total",
Help: "Total number of samples by type",
}, []string{"type"})

reg.MustRegister(sampleWriteRequestBytes)
reg.MustRegister(sampleWrites)
reg.MustRegister(stacktraceWriteRequestBytes)
reg.MustRegister(debuginfoUploadRequestBytes)
reg.MustRegister(emptySamples)
reg.MustRegister(samplesByType)

r := &ParcaReporter{
stopSignal: make(chan libpf.Void),
Expand Down Expand Up @@ -663,6 +677,10 @@ func New(
emptySamples: emptySamples,
stacktraceWriteRequestBytes: stacktraceWriteRequestBytes,
debuginfoUploadRequestBytes: debuginfoUploadRequestBytes,
cpuSamples: samplesByType.WithLabelValues("cpu"),
gpuSamples: samplesByType.WithLabelValues("gpu"),
offcpuSamples: samplesByType.WithLabelValues("offcpu"),
memorySamples: samplesByType.WithLabelValues("memory"),
offlineModeConfig: offlineModeConfig,
offlineModeLoggedStacks: loggedStacks,
}
Expand Down Expand Up @@ -1067,7 +1085,7 @@ func (r *ParcaReporter) reportDataToBackend(ctx context.Context, buf *bytes.Buff
return err
}

log.Infof("[reporter] sending %d samples (%d bytes) to server", record.NumRows(), buf.Len())
log.Debugf("Sending profile with %d samples (%d bytes)", record.NumRows(), buf.Len())

client, err := r.client.Write(ctx)
if err != nil {
Expand Down