*: simplify parca-load and make deterministic #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e queries Signed-off-by: Alfonso Subiotto Marques <[email protected]>
Signed-off-by: Alfonso Subiotto Marques <[email protected]>
This is helpful to keep the labels variable constant over time in order to correctly understand query performance over time. Signed-off-by: Alfonso Subiotto Marques <[email protected]>
This removes variability in query runtimes Signed-off-by: Alfonso Subiotto Marques <[email protected]>
This also reduces query variability Signed-off-by: Alfonso Subiotto Marques <[email protected]>
Now that queries don't share state for discoverability, run them in parallel Signed-off-by: Alfonso Subiotto Marques <[email protected]>
Signed-off-by: Alfonso Subiotto Marques <[email protected]>
brancz
approved these changes
Jan 20, 2026
This was referenced Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to reduce variability across parca-load runs. All variables are now specified via flags (e.g. types you want to query for, label filters you want to use). The default configuration is to discover profile types and run queries for every discovered type.
This change removes data dependencies between queries and therefore allows us to run queries in parallel.
In addition, some improvements to metrics were made to expose label filters and use native histograms.
We are also no longer querying for unused report types in query merge.