ui: Add refresh results to Group by and Sum by dropdowns#5999
Merged
Conversation
|
✅ Meticulous spotted visual differences in 34 of 517 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit 7fc38c1. This comment will update as new commits are pushed. |
yomete
force-pushed
the
groupby-labels
branch
from
5f503f8 to
9994aa8
Compare
manojVivek
approved these changes
Oct 21, 2025
Contributor
manojVivek
left a comment
manojVivek
left a comment
There was a problem hiding this comment.
Just a question, looks good otherwise!
| style={{...innerProps.style, height: '332px', maxHeight: '332px', fontSize: '14px'}} | ||
| > | ||
| {children} | ||
| <div className="flex flex-col" style={{maxHeight: '332px'}}> |
Contributor
There was a problem hiding this comment.
Would it make sense to extract this as a ListWithRefreshButton or so, as we use it in multiple places now?
Not sure how different/similar each one of those usages are though, so just wanted to check.
Contributor
Author
There was a problem hiding this comment.
they technically do the same thing just with different data types.
🤔should be very doable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.