*: HasProfileData endpoint and time range support for ProfileTypes query#6003
*: HasProfileData endpoint and time range support for ProfileTypes query#6003manojVivek merged 9 commits intomainfrom
HasProfileData endpoint and time range support for ProfileTypes query#6003Conversation
pkg/query/columnquery.go
Outdated
| } | ||
|
|
||
| func (q *ColumnQueryAPI) HasProfileData(ctx context.Context, req *pb.HasProfileDataRequest) (*pb.HasProfileDataResponse, error) { | ||
| res, err := q.ProfileTypes(ctx, &pb.ProfileTypesRequest{}) |
There was a problem hiding this comment.
I think this should call q.querier.HasProfileData which is defined differently for querier.go and querier_sql.go. Basically ProfileTypes for querier.go but the SELECT 1 FROM v1.stacktraces LIMIT 1 query in querier_sql.go that we were talking about
There was a problem hiding this comment.
was just about to comment the exact same thing
There was a problem hiding this comment.
Concretely for parca I think this means we should make HasProfileData part of the Querier interface too and this should call q.querier.HasProfileData
|
🔴 Meticulous spotted visual differences in 460 of 493 screens tested: view and approve differences detected. Meticulous evaluated ~5 hours of user flows against your PR. Last updated for commit 7e6b665. This comment will update as new commits are pushed. |
3 participants
This decouples the need for
ProfileTypesendpoint to check if there is profile data available.