Merged
Conversation
|
✅ Meticulous spotted 0 visual differences across 315 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit e29dc18. This comment will update as new commits are pushed. |
metalmatze
approved these changes
Nov 24, 2025
This commit adds two new string filter types to match "contains" and "does not contain": - starts_with: matches strings that start with the specified prefix - not_starts_with: matches strings that do not start with the specified prefix Changes: - proto: Added starts_with and not_starts_with fields to StringCondition message - backend: Updated matchesStringCondition() to handle new filter types using bytes.HasPrefix - frontend UI: Added "Starts With" and "Not Starts With" options to filter dropdown - frontend types: Updated ProfileFilter interface and createStringCondition() for new match types - tests: Added 4 comprehensive tests covering stack and frame filters with both new filter types The implementation follows the same pattern as existing contains/not_contains filters, with case-insensitive matching and proper null handling.
The NotStartsWith filter was being treated as a positive condition, causing incorrect filter logic. Stack filters with negative conditions need ALL functions to not match (AND logic), while positive conditions need ANY function to match (OR logic). Fixed in 4 functions: - handleUnsymbolizedFunctionCondition - matchesFunctionNameInRange - matchesSystemNameInRange - matchesFilenameInRange This fixes the failing TestStackFilterFunctionNameNotStartsWith test.
NewRecordReader now returns (reader, error) instead of just reader. Updated all 4 test cases to handle the error return value.
brancz
force-pushed
the
claude/add-starts-with-filters-01So4CKa83NkKVG2Zmm1nV1d
branch
from
73c3cdf to
e29dc18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds two new string filter types to match "contains" and "does not contain":
Changes:
The implementation follows the same pattern as existing contains/not_contains filters, with case-insensitive matching and proper null handling.