ui: Extend useURLState and useQueryState hooks #6138
+841
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Meticulous spotted 0 visual differences across 328 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 1babb57. This comment will update as new commits are pushed. |
manojVivek
reviewed
Jan 8, 2026
| const result = encodeProfileFilters(value); | ||
| return result; | ||
| }, | ||
| mergeStrategy: 'preserve-existing', |
Contributor
There was a problem hiding this comment.
Is it possible to apply the mergeStrategy in this component and pass the final value into the URLState?
Adding that functionality into the URL State might complicate things a lot.
yomete
force-pushed
the
view-adjustments
branch
from
f605253 to
1c1f139
Compare
yomete
force-pushed
the
view-adjustments
branch
from
491c914 to
a60cdfe
Compare
yomete
force-pushed
the
view-adjustments
branch
from
a60cdfe to
49bd403
Compare
yomete
force-pushed
the
view-adjustments
branch
from
49bd403 to
d2b86db
Compare
This PR refactors the URL state hooks to export raw setters that external wrapper hooks can use. Changes: - useQueryState: Exports raw URL setters (setExpressionParam, setSumByParam, setGroupByParam) for external wrapper hooks - useProfileFilters: Exports setAppliedFilters for wrapper hooks
yomete
force-pushed
the
view-adjustments
branch
from
d2b86db to
1babb57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the URL state hooks to export raw setters that external wrapper hooks can use.
Changes: