Skip to content

feat: support <string> in @property syntax #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 1 commit into from
Jan 20, 2026
+25 −0
Merged

feat: support <string> in @property syntax #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28661,6 +28661,17 @@ mod tests {
"@property --property-name{syntax:\"<length>\";inherits:true;initial-value:25px}",
);

minify_test(
r#"
@property --property-name {
syntax: '<string>';
inherits: true;
initial-value: "hi";
}
"#,
"@property --property-name{syntax:\"<string>\";inherits:true;initial-value:\"hi\"}",
);

error_test(
r#"
@property --property-name {
Expand Down
14 changes: 14 additions & 0 deletions src/values/syntax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ pub enum SyntaxComponentKind {
Percentage,
/// A `<length-percentage>` component.
LengthPercentage,
/// A `<string>` component.
String,
/// A `<color>` component.
Color,
/// An `<image>` component.
Expand Down Expand Up @@ -126,6 +128,8 @@ pub enum ParsedComponent<'i> {
Percentage(values::percentage::Percentage),
/// A `<length-percentage>` value.
LengthPercentage(values::length::LengthPercentage),
/// A `<string>` value.
String(values::string::CSSString<'i>),
/// A `<color>` value.
Color(values::color::CssColor),
/// An `<image>` value.
Expand Down Expand Up @@ -222,6 +226,7 @@ impl<'i> SyntaxString {
SyntaxComponentKind::LengthPercentage => {
ParsedComponent::LengthPercentage(values::length::LengthPercentage::parse(input)?)
}
SyntaxComponentKind::String => ParsedComponent::String(values::string::CSSString::parse(input)?),
SyntaxComponentKind::Color => ParsedComponent::Color(values::color::CssColor::parse(input)?),
SyntaxComponentKind::Image => ParsedComponent::Image(values::image::Image::parse(input)?),
SyntaxComponentKind::Url => ParsedComponent::Url(values::url::Url::parse(input)?),
Expand Down Expand Up @@ -343,6 +348,7 @@ impl SyntaxComponentKind {
"number" => SyntaxComponentKind::Number,
"percentage" => SyntaxComponentKind::Percentage,
"length-percentage" => SyntaxComponentKind::LengthPercentage,
"string" => SyntaxComponentKind::String,
"color" => SyntaxComponentKind::Color,
"image" => SyntaxComponentKind::Image,
"url" => SyntaxComponentKind::Url,
Expand Down Expand Up @@ -440,6 +446,7 @@ impl ToCss for SyntaxComponentKind {
Number => "<number>",
Percentage => "<percentage>",
LengthPercentage => "<length-percentage>",
String => "<string>",
Color => "<color>",
Image => "<image>",
Url => "<url>",
Expand Down Expand Up @@ -467,6 +474,7 @@ impl<'i> ToCss for ParsedComponent<'i> {
Number(v) => v.to_css(dest),
Percentage(v) => v.to_css(dest),
LengthPercentage(v) => v.to_css(dest),
String(v) => v.to_css(dest),
Color(v) => v.to_css(dest),
Image(v) => v.to_css(dest),
Url(v) => v.to_css(dest),
Expand Down Expand Up @@ -640,6 +648,12 @@ mod tests {

test("foo | bar | baz", "bar", ParsedComponent::Literal("bar".into()));

test(
"<string>",
"'foo'",
ParsedComponent::String(values::string::CSSString("foo".into())),
);

test(
"<custom-ident>",
"hi",
Expand Down
Loading