Remove user from Journey #718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pushchris, could you please review this PR? I’ve updated the |
jeroenrinzema
commented
Oct 6, 2025
| .whereNull('ended_at') | ||
| .where('journey_id', ctx.state.journey!.id), | ||
| { ended_at: new Date() }, | ||
| { ended_at: new Date(), type: 'completed' }, |
Author
There was a problem hiding this comment.
Does it make sense to set the type to completed? Is it possible to set the type to exited?
jeroenrinzema
force-pushed
the
feat/remove-from-journey
branch
from
8bec6ff to
4ae0529
Compare
jeroenrinzema
force-pushed
the
feat/remove-from-journey
branch
from
4ae0529 to
cf53d9b
Compare
Author
|
Changes have been tested 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the ability to remove users from a journey.