-
Notifications
You must be signed in to change notification settings - Fork 205
feat(request): make request ID generation on client configurable #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PanGan21
wants to merge
12
commits into
paritytech:master
Choose a base branch
from
PanGan21:1524-request-id-generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
51ad234
implement custom generator on IdKind
PanGan21 0ee2516
refactor next request id to handle the next id
PanGan21 8f7b381
move batch id generation to request id manager
PanGan21 150f07d
simplify implementation
PanGan21 3d714a0
refactor: replaces ranges with vectors of ids
PanGan21 b57905d
Merge branch 'master' into 1524-request-id-generator
PanGan21 556ee8a
add test with an unordered batch response
PanGan21 e4005ac
change test to use custom id generator
PanGan21 a8c2689
fix conflicts
PanGan21 ebae283
fix example
PanGan21 607226a
refactor batches from hashmap to vec
PanGan21 4f6b8e9
Merge branch 'master' into 1524-request-id-generator
PanGan21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// Copyright 2019-2021 Parity Technologies (UK) Ltd. | ||
// | ||
// Permission is hereby granted, free of charge, to any | ||
// person obtaining a copy of this software and associated | ||
// documentation files (the "Software"), to deal in the | ||
// Software without restriction, including without | ||
// limitation the rights to use, copy, modify, merge, | ||
// publish, distribute, sublicense, and/or sell copies of | ||
// the Software, and to permit persons to whom the Software | ||
// is furnished to do so, subject to the following | ||
// conditions: | ||
// | ||
// The above copyright notice and this permission notice | ||
// shall be included in all copies or substantial portions | ||
// of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF | ||
// ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED | ||
// TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A | ||
// PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT | ||
// SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY | ||
// CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION | ||
// OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR | ||
// IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
// DEALINGS IN THE SOFTWARE. | ||
|
||
use std::net::SocketAddr; | ||
|
||
use jsonrpsee::client_transport::ws::{Url, WsTransportClientBuilder}; | ||
use jsonrpsee::core::client::{Client, ClientBuilder, ClientT, IdKind}; | ||
use jsonrpsee::rpc_params; | ||
use jsonrpsee::server::{RpcModule, Server}; | ||
use jsonrpsee::types::{Id, IdGeneratorFn}; | ||
|
||
#[tokio::main] | ||
async fn main() -> anyhow::Result<()> { | ||
tracing_subscriber::FmtSubscriber::builder() | ||
.with_env_filter(tracing_subscriber::EnvFilter::from_default_env()) | ||
.try_init() | ||
.expect("setting default subscriber failed"); | ||
|
||
let addr = run_server().await?; | ||
let uri = Url::parse(&format!("ws://{}", addr))?; | ||
|
||
let custom_generator = IdGeneratorFn::new(generate_timestamp_id); | ||
|
||
let (tx, rx) = WsTransportClientBuilder::default().build(uri).await?; | ||
let client: Client = ClientBuilder::default().id_format(IdKind::Custom(custom_generator)).build_with_tokio(tx, rx); | ||
|
||
let response: String = client.request("say_hello", rpc_params![]).await?; | ||
tracing::info!("response: {:?}", response); | ||
|
||
Ok(()) | ||
} | ||
|
||
async fn run_server() -> anyhow::Result<SocketAddr> { | ||
let server = Server::builder().build("127.0.0.1:0").await?; | ||
let mut module = RpcModule::new(()); | ||
module.register_method("say_hello", |_, _, _| "lo")?; | ||
let addr = server.local_addr()?; | ||
|
||
let handle = server.start(module); | ||
|
||
// In this example we don't care about doing shutdown so let's it run forever. | ||
// You may use the `ServerHandle` to shut it down or manage it yourself. | ||
tokio::spawn(handle.stopped()); | ||
|
||
Ok(addr) | ||
} | ||
|
||
fn generate_timestamp_id() -> Id<'static> { | ||
let timestamp = | ||
std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).expect("Time went backwards").as_secs(); | ||
Id::Number(timestamp) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.