Skip to content

Do not require new source headers at target when only reward confirmations are missing #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
svyatonik wants to merge 1 commit into
base: bridges-v2
Choose a base branch
from
Draft

Do not require new source headers at target when only reward confirmations are missing #1328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions relays/messages/src/message_race_delivery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,15 +320,16 @@ where
) -> Option<SourceHeaderIdOf<P>> {
let header_required_for_messages_delivery =
self.strategy.required_source_header_at_target(current_best);
let header_required_for_reward_confirmations_delivery =
self.latest_confirmed_nonces_at_source.back().map(|(id, _)| id.clone());
match (
header_required_for_messages_delivery,
header_required_for_reward_confirmations_delivery,
) {
(Some(id1), Some(id2)) => Some(if id1.0 > id2.0 { id1 } else { id2 }),
(a, b) => a.or(b),
}
header_required_for_messages_delivery
// let header_required_for_reward_confirmations_delivery =
// self.latest_confirmed_nonces_at_source.back().map(|(id, _)| id.clone());
// match (
// header_required_for_messages_delivery,
// header_required_for_reward_confirmations_delivery,
// ) {
// (Some(id1), Some(id2)) => Some(if id1.0 > id2.0 { id1 } else { id2 }),
// (a, b) => a.or(b),
// }
}

fn best_at_source(&self) -> Option<MessageNonce> {
Expand Down