Skip to content

fix(bounded-collections): Fix scale-codec feature config#925

Merged
bkchr merged 1 commit intoparitytech:masterfrom
dimartiro:master
Jun 23, 2025
Merged

fix(bounded-collections): Fix scale-codec feature config#925
bkchr merged 1 commit intoparitytech:masterfrom
dimartiro:master

Conversation

@dimartiro
Copy link
Contributor

Description

I'm working on updating polkadot-sdk to use the latest version of bounded-collections (0.3.1) to fix an issue related to BoundedBTreeSet (also related to my previous PR).

While doing so, I ran into the following error:

 error[E0432]: unresolved import `scale_codec`
    --> /Users/diego/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bounded-collections-0.3.1/src/codec_utils.rs:75:30
     |
  75 |     impl_prepend_compact_input!(scale_codec);
     |                                 ^^^^^^^^^^^ use of unresolved module or unlinked crate `scale_codec`

I'm not an expert in Rust, but after some experimentation, I found that this change solves the issue when testing with my fork.

That said, I'm open to suggestions if there's a better or more idiomatic way to fix it.

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@bkchr bkchr requested a review from serban300 June 22, 2025 21:12
@bkchr bkchr enabled auto-merge (squash) June 22, 2025 21:12
@bkchr
Copy link
Member

bkchr commented Jun 22, 2025

@serban300 please also create a patch release for this tomorrow.

@bkchr bkchr merged commit 30db760 into paritytech:master Jun 23, 2025
6 checks passed
@serban300
Copy link
Contributor

@serban300 please also create a patch release for this tomorrow.

Done: https://crates.io/crates/bounded-collections/0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants