Conversation
jasl
commented
Sep 5, 2025
|
Odd, this should not cause CI fail |
It's probably related to the |
I pushed a commit that seems to fix this issue: c4d1c8c |
There was a problem hiding this comment.
Can you also take a look at these warnings please:
Compiling bounded-collections v0.3.2 (/Users/runner/work/parity-common/parity-common/bounded-collections)
warning: hiding a lifetime that's elided elsewhere is confusing
Warning: --> bounded-collections/src/bounded_btree_map.rs:216:18
|
216 | pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<K, V> {
| ^^^^^^^^^ -------------------------------------------- the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
|
216 | pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<'_, K, V> {
| +++
warning: hiding a lifetime that's elided elsewhere is confusing
Warning: --> bounded-collections/src/bounded_vec.rs:644:26
|
644 | pub fn as_bounded_slice(&self) -> BoundedSlice<T, S> {
| ^^^^^ ------------------ the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
|
644 | pub fn as_bounded_slice(&self) -> BoundedSlice<'_, T, S> {
| +++
warning: `bounded-collections` (lib) generated 2 warnings
From https://github.com/paritytech/parity-common/actions/runs/17549110821/job/49837218596?pr=937
No problem, I've seen this too |
Head branch was pushed to by a user without write access
|
@serban300 Sorry, one more approval, Copilot missed some deprecation, I caught them and fixed |