Skip to content

Update deprecated usage#937

Merged
serban300 merged 6 commits intoparitytech:masterfrom
jasl:patch-1
Sep 8, 2025
Merged

Update deprecated usage#937
serban300 merged 6 commits intoparitytech:masterfrom
jasl:patch-1

Conversation

@jasl
Copy link
Copy Markdown
Contributor

@jasl jasl commented Sep 5, 2025

image

@jasl jasl changed the title Update bigint.rs Update deprecated usage Sep 5, 2025
@bkchr bkchr requested a review from serban300 September 8, 2025 08:12
@bkchr bkchr enabled auto-merge (squash) September 8, 2025 08:12
@jasl
Copy link
Copy Markdown
Contributor Author

jasl commented Sep 8, 2025

Odd, this should not cause CI fail

@serban300
Copy link
Copy Markdown
Contributor

Odd, this should not cause CI fail

It's probably related to the kvdb-rocksdb update. I'm taking a look

@serban300 serban300 requested a review from a team as a code owner September 8, 2025 11:22
@serban300
Copy link
Copy Markdown
Contributor

Odd, this should not cause CI fail

It's probably related to the kvdb-rocksdb update. I'm taking a look

I pushed a commit that seems to fix this issue: c4d1c8c

Copy link
Copy Markdown
Contributor

@serban300 serban300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also take a look at these warnings please:

   Compiling bounded-collections v0.3.2 (/Users/runner/work/parity-common/parity-common/bounded-collections)
warning: hiding a lifetime that's elided elsewhere is confusing
Warning:    --> bounded-collections/src/bounded_btree_map.rs:216:18
    |
216 |     pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<K, V> {
    |                     ^^^^^^^^^     -------------------------------------------- the same lifetime is hidden here
    |                     |
    |                     the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
    |
216 |     pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<'_, K, V> {
    |                                                                          +++
warning: hiding a lifetime that's elided elsewhere is confusing
Warning:    --> bounded-collections/src/bounded_vec.rs:644:26
    |
644 |     pub fn as_bounded_slice(&self) -> BoundedSlice<T, S> {
    |                             ^^^^^     ------------------ the same lifetime is hidden here
    |                             |
    |                             the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
    |
644 |     pub fn as_bounded_slice(&self) -> BoundedSlice<'_, T, S> {
    |                                                    +++
warning: `bounded-collections` (lib) generated 2 warnings

From https://github.com/paritytech/parity-common/actions/runs/17549110821/job/49837218596?pr=937

@jasl
Copy link
Copy Markdown
Contributor Author

jasl commented Sep 8, 2025

Can you also take a look at these warnings please:

   Compiling bounded-collections v0.3.2 (/Users/runner/work/parity-common/parity-common/bounded-collections)
warning: hiding a lifetime that's elided elsewhere is confusing
Warning:    --> bounded-collections/src/bounded_btree_map.rs:216:18
    |
216 |     pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<K, V> {
    |                     ^^^^^^^^^     -------------------------------------------- the same lifetime is hidden here
    |                     |
    |                     the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
    |
216 |     pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<'_, K, V> {
    |                                                                          +++
warning: hiding a lifetime that's elided elsewhere is confusing
Warning:    --> bounded-collections/src/bounded_vec.rs:644:26
    |
644 |     pub fn as_bounded_slice(&self) -> BoundedSlice<T, S> {
    |                             ^^^^^     ------------------ the same lifetime is hidden here
    |                             |
    |                             the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
    |
644 |     pub fn as_bounded_slice(&self) -> BoundedSlice<'_, T, S> {
    |                                                    +++
warning: `bounded-collections` (lib) generated 2 warnings

From https://github.com/paritytech/parity-common/actions/runs/17549110821/job/49837218596?pr=937

No problem, I've seen this too

auto-merge was automatically disabled September 8, 2025 12:02

Head branch was pushed to by a user without write access

@jasl
Copy link
Copy Markdown
Contributor Author

jasl commented Sep 8, 2025

@serban300 Sorry, one more approval, Copilot missed some deprecation, I caught them and fixed

@serban300 serban300 merged commit cb633d1 into paritytech:master Sep 8, 2025
6 checks passed
@jasl jasl deleted the patch-1 branch September 8, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants