Use marker trait StrictCodec to indicate strict one-to-one correspondance#252
Open
Use marker trait StrictCodec to indicate strict one-to-one correspondance#252
Conversation
Member
|
Gav mentioned in Element chat that he would like to have strict enabled by default, and something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #251. I'd like to put this out for discussions first to see if we like this approach before writing tests and other stuff.
This introduces a marker trait
StrictCodec(together withderive(Strict)). Any types implementingStrictCodecare supposed to have strict one-to-one correspondence. This avoids accidentally introducing those non-strict types when it matters -- for example, when we need to handle user inputs and want to have peace of mind that we can freely decode and encode stuff.