Skip to content

Conversation

0xRVE
Copy link
Contributor

@0xRVE 0xRVE commented Oct 16, 2025

adds more funded accounts to eth-rpc and dev-node

@0xRVE 0xRVE added the T7-smart_contracts This PR/Issue is related to smart contracts. label Oct 16, 2025
@0xRVE 0xRVE requested a review from pgherveou October 16, 2025 14:44
@0xRVE
Copy link
Contributor Author

0xRVE commented Oct 16, 2025

/cmd prdoc --audience runtime_dev --bump patch

@pgherveou
Copy link
Contributor

can we add a few more 0 to the initial fundings of these accounts

@pgherveou pgherveou requested a review from marian-radu October 16, 2025 15:08
Copy link
Contributor

@marian-radu marian-radu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pgherveou pgherveou enabled auto-merge October 16, 2025 15:25
@pgherveou
Copy link
Contributor

We need to update the evm-test-suite here

 FAIL   unit  src/methods.test.ts > eth-rpc > eth_accounts works
AssertionError: expected [ …(5) ] to have a length of 1 but got 5

- Expected
+ Received

- 1
+ 5

 ❯ src/methods.test.ts:30:31
     28|                 method: 'eth_accounts',
     29|             })
     30|             expect(addresses).toHaveLength(1)
       |     

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/18590609553
Failed job name: test-linux-stable

@0xRVE
Copy link
Contributor Author

0xRVE commented Oct 17, 2025

We need to update the evm-test-suite here

paritytech/evm-test-suite#117

@0xRVE 0xRVE requested review from a team as code owners October 17, 2025 12:24
@0xRVE
Copy link
Contributor Author

0xRVE commented Oct 17, 2025

/cmd prdoc --audience runtime_dev --bump patch

@pgherveou
Copy link
Contributor

We need to update the evm-test-suite here

paritytech/evm-test-suite#117

actually the evm-test-suite is called differently now, se the diff of #10018

@0xRVE
Copy link
Contributor Author

0xRVE commented Oct 19, 2025

/cmd prdoc --audience runtime_dev --bump patch

@pgherveou pgherveou added this pull request to the merge queue Oct 19, 2025
Merged via the queue into master with commit 590f23d Oct 19, 2025
243 of 244 checks passed
@pgherveou pgherveou deleted the rve/scc-168-dragonswap branch October 19, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants