-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Set a proper proof size block limit #10535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
…lkadot-sdk into torsten/dev-node-pov-limit
it was using the default and not the one defined in this file
Differential Tests Results (REVM)Specified Tests
Counts
FailuresThe test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information Detailed Differential Tests Failure Information
|
Differential Tests Results (PolkaVM)Specified Tests
Counts
FailuresThe test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information Detailed Differential Tests Failure Information
|
|
yeah with these changes we are now getting these errors |
…lkadot-sdk into torsten/dev-node-pov-limit
|
/cmd bench --runtime dev --pallet pallet_revive |
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
…--pallet pallet_revive'
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
…lkadot-sdk into torsten/dev-node-pov-limit
The current block limit of the revive dev node defined its
proof_sizeasu64::MAX.This is a reasonable setting for a standalone chain as the PoV as a limiting resource is only relevant for parachains.
However, this gives some confusing gas mapping calculations: they are correct and consistent but the resulting
proof_sizeweights are unexpectedly high.This PR sets the
proof_sizeof the block limit to the same value as the Polkadot Asset Hub.