Skip to content

Conversation

@lexnv
Copy link
Contributor

@lexnv lexnv commented Dec 4, 2025

This PR ensures that the parachains test-utils crate has 2 relay parent descendants for testing purposes.

Effectively fixes a panic because we missed this mock data for chains that started with RP_offset > 0:

 Unable to verify provided relay parent descendants. expected_rp_descendants_num: 1 error: InvalidNumberOfDescendants { expected: 2, received: 0 }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Detected in:

Unblocks:

Inspired by a similar fix I've introduced in:

@lexnv lexnv self-assigned this Dec 4, 2025
@lexnv lexnv added T0-node This PR/Issue is related to the topic “node”. T10-tests This PR/Issue is related to tests. labels Dec 4, 2025
@lexnv
Copy link
Contributor Author

lexnv commented Dec 4, 2025

/cmd prdoc --audience node_dev --bump patch

@lexnv
Copy link
Contributor Author

lexnv commented Dec 8, 2025

/cmd prdoc --audience node_dev --bump patch --force

github-actions bot and others added 2 commits December 8, 2025 13:28
lexnv added 2 commits December 9, 2025 11:18
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv requested review from a team as code owners December 9, 2025 11:19
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/20063578165
Failed job name: test-linux-stable

@lexnv
Copy link
Contributor Author

lexnv commented Dec 9, 2025

/cmd prdoc --audience node_dev --bump patch --force

@lexnv lexnv enabled auto-merge December 9, 2025 16:14
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv added this pull request to the merge queue Dec 10, 2025
Merged via the queue into master with commit 0f28d81 Dec 10, 2025
227 of 230 checks passed
@lexnv lexnv deleted the lexnv/fix-descendants branch December 10, 2025 12:35
@lexnv lexnv added A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-stable2509 Pull request must be backported to the stable2509 release branch A4-backport-stable2512 Pull request must be backported to the stable2512 release branch labels Dec 10, 2025
@paritytech-release-backport-bot

Created backport PR for stable2506:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10541-to-stable2506
git worktree add --checkout .worktree/backport-10541-to-stable2506 backport-10541-to-stable2506
cd .worktree/backport-10541-to-stable2506
git reset --hard HEAD^
git cherry-pick -x 0f28d8104be04cb13ac39ccfd17240f703953c33
git push --force-with-lease

@paritytech-release-backport-bot

Created backport PR for stable2509:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10541-to-stable2509
git worktree add --checkout .worktree/backport-10541-to-stable2509 backport-10541-to-stable2509
cd .worktree/backport-10541-to-stable2509
git reset --hard HEAD^
git cherry-pick -x 0f28d8104be04cb13ac39ccfd17240f703953c33
git push --force-with-lease

paritytech-release-backport-bot bot pushed a commit that referenced this pull request Dec 10, 2025
…ata (#10541)

This PR ensures that the parachains test-utils crate has 2 relay parent
descendants for testing purposes.

Effectively fixes a panic because we missed this mock data for chains
that started with `RP_offset > 0`:

```
 Unable to verify provided relay parent descendants. expected_rp_descendants_num: 1 error: InvalidNumberOfDescendants { expected: 2, received: 0 }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```

Detected in:
-
https://github.com/polkadot-fellows/runtimes/actions/runs/19857064730/job/56897622908?pr=1018

Unblocks:
- polkadot-fellows/runtimes#1018

Inspired by a similar fix I've introduced in:
- #9880

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 0f28d81)
@paritytech-release-backport-bot

@lexnv lexnv added A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch and removed A4-backport-stable2506 Pull request must be backported to the stable2506 release branch labels Dec 10, 2025
@paritytech-release-backport-bot

Created backport PR for unstable2507:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10541-to-unstable2507
git worktree add --checkout .worktree/backport-10541-to-unstable2507 backport-10541-to-unstable2507
cd .worktree/backport-10541-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x 0f28d8104be04cb13ac39ccfd17240f703953c33
git push --force-with-lease

EgorPopelyaev added a commit that referenced this pull request Dec 10, 2025
Backport #10541 into `stable2512` from lexnv.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Alexandru Vasile <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Egor_P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2509 Pull request must be backported to the stable2509 release branch A4-backport-stable2512 Pull request must be backported to the stable2512 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch T0-node This PR/Issue is related to the topic “node”. T10-tests This PR/Issue is related to tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants