Introduce Preimage in Pallet Collective #10565
Open
+47
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Dec 7, 2025
Comment on lines
444
to
+445
| pub type ProposalOf<T: Config<I>, I: 'static = ()> = | ||
| StorageMap<_, Identity, T::Hash, <T as Config<I>>::Proposal, OptionQuery>; | ||
| StorageMap<_, Identity, T::Hash, (), OptionQuery>; |
Member
There was a problem hiding this comment.
Should be removed and migrated with a multi block migration to Preimage
| type RuntimeOrigin: From<RawOrigin<Self::AccountId, I>>; | ||
|
|
||
| /// The runtime call dispatch type. | ||
| type Proposal: Parameter |
Member
There was a problem hiding this comment.
Could be also removed and replaced by frame_system::Config::RuntimeCall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intorduces Preimage in pallet Collective (via QueryPreimage + StorePreimage traits) for proposal storage. This allows the collective pallet to perform cheap O(1) length checks using the preimage metadata before incurring the cost of fetching the full proposal data.
closes #10209