pallet-dap: treasury burns / slashing into DAP #10576
Open
+804
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an initial version of the Dynamic Allocation Pool (DAP). It makes possible to collect funds that would otherwise be burned, into the DAP buffer on AssetHub. On Westend AssetHub: - Treasury unspent and staking slashes are now redirected to the DAP buffer instead of being burned. - All user-initiated burns also go to the DAP buffer instead of reducing total issuance. Events: - FundsReturned is emitted only for explicit user actions (e.g., burn extrinsic via FundingSink). Automatic system operations like fee handling and slashes via OnUnbalanced do NOT emit events to avoid bloating blocks with tons of events per block.
This is done in order to reduce the scope of the initial changes. We comment out the BurnDestination from pallet-balances config so that we avoid to introduce a breaking change for all runtimes. This is initially acceptable since burn extrinsic is rarely used.
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
sigurpol
added
A4-backport-stable2509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces the foundation for the
Dynamic Allocation Pool(DAP) system:FundingSink trait (
frame-support): A new trait for returning funds to an issuance system.Implementations can either burn directly (
DirectBurn) or return to a buffer for reuse.pallet-dap: A new pallet that implements
FundingSinkby collecting funds into a bufferaccount instead of burning them. The buffer account is created via
inc_providersat genesisor on runtime upgrade, ensuring it can receive any amount including those below ED.
AssetHub Westend integration: The runtime now uses pallet-dap to redirect dtaking slashes to the DAP buffer (via
SlashToDap)Treasury burns are now disabled so no need to integrate with DAP: treasury
Burnparameter is setto zero in Westend RC, AssetHub and collective runtimes. This means no treasury funds are burned at
the end of spend periods, preserving total issuance.
NOTE: User-initiated burns (via
pallet_balances::burn extrinsic) do NOT go through DAP currently but they burn directly instead, reducing total issuance immediately. This is becausepallet_balances::BurnDestinationin the related pallet's Config is commented out.In the moment we uncomment it, we will introduce a breaking change forcing:
BurnDestination = DirectBurn<Runtime>(this makes the burn extrinsic actually burn tokens so same behavior as before).This was not included in this PR to keep the scope limited, especially since user-initiated burns are rare events.
🔜 Coming soon
This is the first deliverable of the DAP system. Future PRs will include:
🐛 Related issue
Close #10485 .
📖 Related links